ConcurrentModificationException with some mods #126

New issue

Open

opened 2024-08-17 13:49:02 +00:00 by forkiesassds · 1 comment

forkiesassds commented

2024-08-17 13:49:02 +00:00

(Migrated from github.com)

Some mods (or possibly even large enough Resource Packs) can cause a ConcurrentModificationException with this library. The way to fix it would be to change the mixin in TextureManager to target the lambda that calls register instead of calling the mixin code right before returning the CompletableFuture which could still be running code.

Here are the logs that were posted in a bug report involving Nostalgic Tweaks and this library causing the game to crash: https://paste.ee/p/ftqqd

Some mods (or possibly even large enough Resource Packs) can cause a ConcurrentModificationException with this library. The way to fix it would be to change the mixin in `TextureManager` to target the lambda that calls `register` instead of calling the mixin code right before returning the CompletableFuture which could still be running code. Here are the logs that were posted in a bug report involving Nostalgic Tweaks and this library causing the game to crash: https://paste.ee/p/ftqqd

Lucraft commented

2024-08-17 14:27:30 +00:00

(Migrated from github.com)

I wont be home for the next 1.5 weeks, after that I can look into the issue